experimental offchain tables #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* . * . * insert and update * delete * realtime * relations * onchain offchain * remove ponder.offchain.schema * cleanup
* . * start new indexing store * upsert * start jsdoc * jsdoc * onchain vs offchain * use text as hex column type * faster * indexing store errors and retry * finish trigger based reorg * fix namespace support
0xOlias
reviewed
Oct 8, 2024
|
|
||
| for (const tableName of tableNames) { | ||
| const columns = getTableColumns(args.schema[tableName]! as PgTable); | ||
| const columns = getTableColumns(args.schema[jsTableName]! as PgTable); | ||
|
|
||
| const columnNames = Object.values(columns).map( |
There was a problem hiding this comment.
Might this also run into JS vs SQL naming issues?
0xOlias
reviewed
Oct 8, 2024
Comment on lines
+1145
to
+1146
| const sqlTableNames = getSQLTableNames(); | ||
| const jsTableNames = getJsTableNames(); |
There was a problem hiding this comment.
I wonder if an API like function getTableNames(): { js: string; sql :string }[] would be safer
* Fixup types and metrics * Uses kysely pglite as dialect provider * Convert sqlite to pglite * tweaks * most tests working * type fixes --------- Co-authored-by: typedarray <[email protected]>
kyscott18
added a commit
that referenced
this pull request
Oct 18, 2024
This reverts commit fddfe27.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.